mark errors as limit error#2048
Merged
Merged
Conversation
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a common marker interface for settings “limit” errors so they can be programmatically detected via errors.As, and adds a capability-layer helper to wrap limit breaches as public user errors.
Changes:
- Added
limits.LimitErrormarker interface and implemented it across existing limit-related error types. - Added unit tests ensuring
errors.Asdetects all limit error types (including when wrapped). - Added
capabilities/errors.NewLimitBreachedErrorto create aLimitExceededcapability error from alimits.LimitError.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/settings/limits/errors.go | Introduces LimitError and tags existing limit-related error types with it. |
| pkg/settings/limits/errors_test.go | Adds positive/negative tests for detecting LimitError via errors.As. |
| pkg/capabilities/errors/error.go | Adds NewLimitBreachedError constructor wrapping a limits.LimitError as a capability error with LimitExceeded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+117
to
+121
| // NewLimitBreachedError creates a public user error that embeds the provided limit error, indicating that a CRE limit | ||
| // breach has occurred. The error message will include the provided errorMsg as a prefix for additional context. | ||
| func NewLimitBreachedError(errorMsg string, err limits.LimitError) Error { | ||
| return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded) | ||
| } |
Comment on lines
+117
to
+121
| // NewLimitBreachedError creates a public user error that embeds the provided limit error, indicating that a CRE limit | ||
| // breach has occurred. The error message will include the provided errorMsg as a prefix for additional context. | ||
| func NewLimitBreachedError(errorMsg string, err limits.LimitError) Error { | ||
| return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded) | ||
| } |
Comment on lines
+117
to
+121
| // NewLimitBreachedError creates a public user error that embeds the provided limit error, indicating that a CRE limit | ||
| // breach has occurred. The error message will include the provided errorMsg as a prefix for additional context. | ||
| func NewLimitBreachedError(errorMsg string, err limits.LimitError) Error { | ||
| return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded) | ||
| } |
jmank88
reviewed
May 12, 2026
ettec
force-pushed
the
common-limit-errors
branch
from
e67f34d to
3fcfb21
Compare
jmank88
reviewed
May 12, 2026
jmank88
reviewed
May 12, 2026
ettec
force-pushed
the
common-limit-errors
branch
from
17f6baa to
faf1127
Compare
agparadiso
approved these changes
May 13, 2026
cedric-cordenier
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.